Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the GeoLineStrings archetype and support it in the map view #7968

Merged
merged 28 commits into from
Nov 7, 2024
Merged

Introduce the GeoLineStrings archetype and support it in the map view #7968

merged 28 commits into from
Nov 7, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 1, 2024 •
edited by github-actions bot
Loading

What

☝🏻 title

  • New GeoLineStrings archetype, using a new GeoLineString component
  • Support it in the map view
  • Fix heuristics for the map view: now a $origin = / single view will be spawned whenever a single GeoXXX entity exists anywhere.
  • Snippets and screenshot for GeoPoints
  • Snippet for GeoLineStrings (but not screenshot, blocked on Add round joints to line strips #829)
  • Added some types to rerun.hpp
  • Fixed/copy/pasted LineStrip2D edit ui for GeoLineString
  • Add python unit tests for GeoPoints
  • Add python unit tests for GeoLineStrings

Switzerland boundaries according to a couple of AIs and an official source:

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view labels Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Deployed docs

Commit Link
e106a3b https://landing-4dxzv3197-rerun.vercel.app/docs

@abey79 abey79 force-pushed the antoine/linestrip branch from 439a8f7 to a0020fe Compare November 1, 2024 10:58
@abey79 abey79 mentioned this pull request Nov 1, 2024
Closed
27 tasks
@abey79 abey79 marked this pull request as ready for review November 1, 2024 18:24
@abey79 abey79 force-pushed the antoine/linestrip branch 5 times, most recently from 67ceb7a to 2324aea Compare November 2, 2024 17:44
emilk
emilk requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel very uneasy with an interface that doesn't explicitly spell out the order of latitude and longitude for all our map primitives, consider this has been the source of bugs for so many years for so many people

crates/store/re_types/definitions/rerun/archetypes/geo_line_strings.fbs Show resolved Hide resolved
crates/store/re_types/definitions/rerun/components/geo_line_string.fbs Outdated Show resolved Hide resolved
crates/store/re_types/src/components/geo_line_string_ext.rs Show resolved Hide resolved
crates/viewer/re_component_ui/src/geo_line_string.rs Outdated Show resolved Hide resolved
crates/viewer/re_component_ui/src/geo_line_string.rs Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_line_string_simple.py Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_line_string_simple.cpp Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_point_simple.cpp Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_point_simple.py Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_point_simple.rs Outdated Show resolved Hide resolved
Base automatically changed from andreas/re_renderer-in-map to main November 4, 2024 11:47
An error occurred while trying to automatically change base from andreas/re_renderer-in-map to main November 4, 2024 11:47
@abey79 abey79 force-pushed the antoine/linestrip branch from 5a29c80 to af9756c Compare November 4, 2024 14:11
@abey79 abey79 removed the do-not-merge Do not merge this PR label Nov 4, 2024
emilk
emilk approved these changes Nov 4, 2024
View reviewed changes
rerun_cpp/src/rerun/archetypes/geo_points_ext.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/components/geo_line_string_ext.cpp Outdated Show resolved Hide resolved
@teh-cmc teh-cmc mentioned this pull request Nov 6, 2024
Closed
@abey79
Copy link
Member Author

abey79 commented Nov 6, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11704123409

abey79 and others added 19 commits November 7, 2024 15:10
@abey79 @teh-cmc
more lint fixes
8f552bb
@abey79 @teh-cmc
moar lint
68e5a92
@abey79 @teh-cmc
Default line radius 2.0 ui points + revert some messy diff
614a54b
@abey79 @teh-cmc
Added edit ui for GeoLineString (based on LineStrip2D)
36eb768
@abey79 @teh-cmc
Add python unit tests for GeoPoints
1d4cf02
@abey79 @teh-cmc
Add python unit tests for GeoLineStrings
42269ca
@abey79 @teh-cmc
Added url to epsg:4326 + clarified degree & N/E positive for lat/lon
1cd5f76
@abey79 @teh-cmc
Update C++ and Rust snippet to make constructors more explicit about …
67aee35 
…lat/lon ordering
@abey79 @teh-cmc
Add explicit from_lat_lon and from_lon_lat to GeoPoints in Python
cbb267a
@abey79 @teh-cmc
All Python constructor now have lat_lon= kw-only argument + revert …
d969073 
…the custom constructors
@abey79 @teh-cmc
Fix GeoLineString ui
2c221fc
@abey79 @teh-cmc
Custom ui for LatLon
778c47c
@abey79 @emilk @teh-cmc
Update rerun_cpp/src/rerun/archetypes/geo_points_ext.cpp
cc0e527 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@abey79 @emilk @teh-cmc
Update rerun_cpp/src/rerun/components/geo_line_string_ext.cpp
b262a00 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@abey79 @teh-cmc
codegen
1925d6d
@abey79 @teh-cmc
codegen
314e3f1
@abey79 @teh-cmc
Fix map view example snippet
63425de
@abey79 @teh-cmc
Codegen, again
6e162e9
@teh-cmc
do not ever drain ALL_RECORDINGS
eb90eb4
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Latest documentation preview deployed successfully.

Result Commit Link
✅ eb90eb4 https://landing-1c0dkxexh-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@abey79 abey79 merged commit aab0b4e into main Nov 7, 2024
42 checks passed
@abey79 abey79 deleted the antoine/linestrip branch November 7, 2024 14:59
@abey79 abey79 mentioned this pull request Nov 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abey79 @emilk @teh-cmc