Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we compile the binaries we upload to GitHub with -F nasm #7669

Closed
emilk opened this issue Oct 9, 2024 · 1 comment · Fixed by #7742
Closed

Make sure we compile the binaries we upload to GitHub with -F nasm #7669

emilk opened this issue Oct 9, 2024 · 1 comment · Fixed by #7742
Assignees
@emilk
Labels
⛴ release Related to shipping or publishing 🎞️ video
Milestone
0.19 - Dataframe ...

Comments

@emilk
Copy link
Member

emilk commented Oct 9, 2024 •
edited
Loading

See #7661 (comment) for more

We need to resolve this first though, one way or another:
@emilk emilk added ⛴ release Related to shipping or publishing 🎞️ video labels Oct 9, 2024
@emilk emilk added this to the 0.19 - Dataframe and web video milestone Oct 9, 2024
@emilk emilk mentioned this issue Oct 9, 2024
Merged
6 tasks
@emilk
Copy link
Member Author

emilk commented Oct 15, 2024

Apparently the -F nasm feature makes a 25x perf difference for @teh-cmc on Linux 64.

Based on that, I think we should disable av1 decoding without -F nasm on Linux and Windows (Mac is fast even without it).

@emilk emilk self-assigned this Oct 15, 2024
@emilk emilk mentioned this issue Oct 15, 2024
Merged
6 tasks
emilk added a commit that referenced this issue Oct 15, 2024
@emilk
Require nasm for AV1 decoding, unless on arm64 macOS (#7742)
6fb673b 
### What
* Closes #7669
* Closes #7671
* Disable AV1 decoding unless the `nasm` feature is turned on
* Turn on the `nasm` feature when building pre-built binaries
* Print enabled video features with `rerun --version` to make testing of
the above easy

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7742?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7742?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7742)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
⛴ release Related to shipping or publishing 🎞️ video
Projects
None yet
Milestone
0.19 - Dataframe and video
Development

Successfully merging a pull request may close this issue.

Require nasm for AV1 decoding, unless on arm64 macOS rerun-io/rerun
1 participant
@emilk