Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not silence walkers::download in re_log #8077

Open
Tracked by #7877
abey79 opened this issue Nov 11, 2024 · 0 comments
Open
Tracked by #7877

Do not silence walkers::download in re_log #8077

abey79 opened this issue Nov 11, 2024 · 0 comments
Labels
feat-map-view Everything related to the map view

Comments

@abey79
Copy link
Member

abey79 commented Nov 11, 2024

We explicitly silence walkers::download in re_log because of:

We should stop doing that when this issue is resolved.

@abey79 abey79 added the feat-map-view Everything related to the map view label Nov 11, 2024
abey79 added a commit that referenced this issue Nov 11, 2024
### What

Short-term workaround for
podusowski/walkers#224

Should be reverted ASAP:
- #8077

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8078?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8078?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/8078)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-map-view Everything related to the map view
Projects
None yet
Development

No branches or pull requests

1 participant