Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new CI workflows on pull-request #1955

Merged
merged 116 commits into from
Apr 25, 2023
Merged
Changes from 1 commit
Commits
Show all changes
116 commits
Select commit Hold shift + click to select a range
cfb141f
New reusable workflow for linting
jleibs Apr 20, 2023
817419c
Reusable workflow to build/test wheels
jleibs Apr 20, 2023
e0a65d3
Get rid of windows error with an extra gate
jleibs Apr 20, 2023
9a9a3fb
Upload/download artifact
jleibs Apr 20, 2023
f5e9a00
Remove deprecated ::set-output
jleibs Apr 20, 2023
35f269b
more linting
jleibs Apr 20, 2023
8bca6ed
Trying to debug EXPECTED_VERSION
jleibs Apr 20, 2023
6868331
Fixing github output
jleibs Apr 20, 2023
55acf6d
Replace cargo-deny matrix with a script
jleibs Apr 20, 2023
83cf5db
Share cache key between build-and-test / linting
jleibs Apr 20, 2023
bbae14b
Actually checkout code when running tests
jleibs Apr 20, 2023
3a00fee
Switch to sccache
jleibs Apr 21, 2023
1ab9d3c
Remove --deny warnings for rustflags
jleibs Apr 21, 2023
601ae97
New workflow for packaging and uploading
jleibs Apr 21, 2023
ce5c50f
Update manual dispatch to pass EXPECTED_VERSION
jleibs Apr 21, 2023
56eeac0
Remove PLATFORM from package since it's part of matrix
jleibs Apr 21, 2023
b757365
Plumb through BUILD flags
jleibs Apr 21, 2023
77e6a60
two-stage matrix
jleibs Apr 21, 2023
f4f2faf
Was missing pytest from non-linux builds
jleibs Apr 21, 2023
bae4490
Refactor matrix as several build jobs again
jleibs Apr 21, 2023
a784b8a
Pass through platform on packaging jobs
jleibs Apr 21, 2023
ac7dcbe
Always patch for prerelease if it's not a release
jleibs Apr 21, 2023
40e4a45
Push wheels to gcloud
jleibs Apr 21, 2023
fa4d248
Add job for running benchmarks
jleibs Apr 21, 2023
f818f09
Inherit secrets
jleibs Apr 21, 2023
a1aad07
Add missing permissions
jleibs Apr 21, 2023
470ec17
Include steps to upload docs
jleibs Apr 21, 2023
a0db139
Lighter bar for separation
jleibs Apr 21, 2023
ef40c45
Remove multi-line if
jleibs Apr 21, 2023
ef5b989
jobs for building and uploading to web
jleibs Apr 21, 2023
bc88d69
Lints is doing a lot more than linting
jleibs Apr 21, 2023
cac23df
Use the right scripts
jleibs Apr 21, 2023
2efe347
Fix input param for build web
jleibs Apr 21, 2023
1891567
More renaming lints -> checks
jleibs Apr 21, 2023
6114558
More naming
jleibs Apr 21, 2023
03b9853
More name cleanup
jleibs Apr 21, 2023
4213c8f
Introduce new faster job for e2e tests to use in CI
jleibs Apr 22, 2023
4f8e4b7
Refactor args to stay under 10
jleibs Apr 22, 2023
934ea00
Can't use develop in our environment so use build / pip install
jleibs Apr 22, 2023
6f2b0bb
Use the same build-and-test-wheels for the fast job
jleibs Apr 22, 2023
8fdf39f
More parameterization
jleibs Apr 22, 2023
e1f17cc
Rename maturin arg
jleibs Apr 22, 2023
0c5f9fd
Still enable extension-module feature
jleibs Apr 22, 2023
72ef833
Default wheel platforms to none
jleibs Apr 22, 2023
bb28327
Fix typo in web artifact
jleibs Apr 22, 2023
a9b69d9
Rename packages -> builds
jleibs Apr 22, 2023
90421a6
New plumbing for PR summary page
jleibs Apr 22, 2023
833277a
Fix PR template
jleibs Apr 22, 2023
a20b408
Add uploaded wheel to PR summary
jleibs Apr 22, 2023
8389afd
PR job needs permissions
jleibs Apr 22, 2023
ec4e5bb
Move the jinja inocation to a script that calls j2
jleibs Apr 22, 2023
0210121
Set up gcloud APIs
jleibs Apr 22, 2023
d1e5b71
Forgot to auth so we can upload the results
jleibs Apr 22, 2023
295c34e
Fix the PR summary script
jleibs Apr 22, 2023
688add5
new job to just build the wheels for a PR
jleibs Apr 22, 2023
10b1663
Use correct output path
jleibs Apr 22, 2023
2295e3d
Fix RUN_TESTS check now that the build and test happen in one step
jleibs Apr 22, 2023
579f8c2
Migrate the summary script to python
jleibs Apr 22, 2023
4675c9f
Lints
jleibs Apr 22, 2023
118d861
Python script needs the github token
jleibs Apr 22, 2023
5915a9a
More NOLINT for PyGithub
jleibs Apr 22, 2023
a4baa72
Add new mechanism to override the upload commit
jleibs Apr 22, 2023
c6ed4e2
Use new CI workflows on pull-request
jleibs Apr 21, 2023
4316b7b
Enable concurrency check for on_pull_request
jleibs Apr 22, 2023
2ee0a03
Override the commit used for uploading web
jleibs Apr 22, 2023
c97b9af
Don't gate wheel-upload on running the tests since we can't run tests…
jleibs Apr 22, 2023
4e5cd9d
Merge branch 'jleibs/refactor_ci' into jleibs/new_ci_on_pr
jleibs Apr 22, 2023
4bf9ded
Split out the deploy docs workflow
jleibs Apr 24, 2023
009482e
Comment and dep cleanup
jleibs Apr 24, 2023
0404db9
Clarify RELEASE_VERSION
jleibs Apr 24, 2023
2b332b7
The version check now happens between RELEASE_VERSION rather than GIT…
jleibs Apr 24, 2023
492bf5d
Upload wheels no longer needs the expected value
jleibs Apr 24, 2023
52e60c5
More sane defaults
jleibs Apr 24, 2023
27dfcdf
Fix bad workflow edit
jleibs Apr 24, 2023
52ae3a5
Add manual_ prefix to build_wheels_for_PR
jleibs Apr 24, 2023
4fe2265
Send build_summary to index.html
jleibs Apr 24, 2023
14d5c90
Standardize on more common - in github action names
jleibs Apr 25, 2023
fc193be
Clearer descriptions and README
jleibs Apr 25, 2023
576f359
More tweaks
jleibs Apr 25, 2023
15e2da9
Remove needs from Save PR
jleibs Apr 25, 2023
a1b63cc
Merge branch 'main' into jleibs/refactor_ci
jleibs Apr 25, 2023
ca9f7a9
Merge branch 'jleibs/refactor_ci' into jleibs/new_ci_on_pr
jleibs Apr 25, 2023
140965f
Some name cleanup
jleibs Apr 25, 2023
66a59ab
Clean up copy-pasted comments
jleibs Apr 25, 2023
830872b
Merge branch 'jleibs/refactor_ci' into jleibs/new_ci_on_pr
jleibs Apr 25, 2023
bfce671
Fix some inputs
jleibs Apr 25, 2023
d32e3d3
Cleanup manual_build_wheels_for_pr
jleibs Apr 25, 2023
901417e
Detect PR rather than needing to enter it via form
jleibs Apr 25, 2023
0b1f940
Merge branch 'main' into jleibs/refactor_ci
jleibs Apr 25, 2023
dce9778
Merge branch 'jleibs/refactor_ci' into jleibs/new_ci_on_pr
jleibs Apr 25, 2023
0f4c826
Index helper for prerelease wheels
jleibs Apr 25, 2023
2d5e240
Add job for pushing to main
jleibs Apr 25, 2023
1b026c5
Fix typo
jleibs Apr 25, 2023
71beb3f
Add new bench comparison functionality to reusable bench
jleibs Apr 25, 2023
e3de727
Cleanup generate_pr_summary.py
jleibs Apr 25, 2023
395bbd2
Merge branch 'main' into jleibs/refactor_ci
jleibs Apr 25, 2023
bd5c57e
Merge branch 'jleibs/refactor_ci' into jleibs/new_ci_on_pr
jleibs Apr 25, 2023
b92bb86
Refactor generate_prerelease_pip_index.py to take args
jleibs Apr 25, 2023
a6759e9
Manual job for benchmarks
jleibs Apr 25, 2023
7aee304
Fix typo in resuable bench
jleibs Apr 25, 2023
d42a6e0
Fix bench naming logic
jleibs Apr 25, 2023
5fcd31a
Runner.tmp isn't available in the docker container
jleibs Apr 25, 2023
92cba84
Add extension to recommendations and readme
jleibs Apr 25, 2023
cf7e0f8
Merge branch 'jleibs/refactor_ci' into jleibs/new_ci_on_pr
jleibs Apr 25, 2023
e2f7925
Upload benches to the right path
jleibs Apr 25, 2023
1243cfb
Clean up some bench step naming
jleibs Apr 25, 2023
cf6b5cd
Add permissions and parameterize fail on alert
jleibs Apr 25, 2023
84b5683
Actually include benchcmp command
jleibs Apr 25, 2023
bf18276
Move benchmp into the docker image
jleibs Apr 25, 2023
fce2535
Fix benchmark upload path
jleibs Apr 25, 2023
732a781
Add benchmark results to the PR summary page
jleibs Apr 25, 2023
ad94a31
Missing "
jleibs Apr 25, 2023
28f6ad1
Merge branch 'main' into jleibs/new_ci_on_pr
jleibs Apr 25, 2023
3dae2c1
Reorder the download/uploads in named bench
jleibs Apr 25, 2023
07ff836
Manual run bench should update the PR summary
jleibs Apr 25, 2023
4ec98f0
Use new url for pr number
jleibs Apr 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up some bench step naming
  • Loading branch information
jleibs committed Apr 25, 2023
commit 1243cfb7da1fc9fd44f9cd4d84bf675409f42146
4 changes: 2 additions & 2 deletions .github/workflows/reusable_bench.yml
Original file line number Diff line number Diff line change
@@ -121,7 +121,7 @@ jobs:

# Gcloud upload action depends on local filename for destination filename
# TODO(jleibs) make this whole thing a python script
- name: "Upload named bench to GCS"
- name: "Copy bench to named file"
if: ${{ inputs.BENCH_NAME != '' }}
run: cp /tmp/${{ env.SHORT_SHA }} /tmp/${{ inputs.BENCH_NAME }}

@@ -132,7 +132,7 @@ jobs:
path: /tmp/${{ inputs.BENCH_NAME }}
destination: "rerun-builds/benches/"

- name: Download file from GCS
- name: Download comparison bench from GCS
if: ${{ inputs.COMPARE_TO != '' }}
run: |
gsutil cp gs://rerun-builds/benches/${{inputs.COMPARE_TO}} /tmp/${{ inputs.COMPARE_TO }}