native_viewer is now an opt-in feature of the rerun library
#2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves compile-times for users that use an external rerun binary. The `rerun` binary, on the other hand, now has `native_viewer` as a _required_ feature. In is an unhappy compromise. Closes #1997
emilk
added
🧑💻 dev experience
teh-cmc
approved these changes
May 9, 2023
| @@ -7,7 +7,7 @@ license = "MIT OR Apache-2.0" | |||
| publish = false | |||
|
|
|||
| [dependencies] | |||
| rerun = { path = "../../../crates/rerun", features = ["web_viewer"] } | |||
| rerun = { path = "../../../crates/rerun", features = ["native_viewer"] } | |||
There was a problem hiding this comment.
dna always uses native_viewer::spawn, never web
| # For the `rerun` binary, always add the `native_viewer` feature. | ||
| # See https://github.com/rerun-io/rerun/issues/1997 | ||
| name = "rerun" | ||
| required-features = ["native_viewer"] |
There was a problem hiding this comment.
Should we maybe also put the web-viewer for this one...? that would avoid the dreaded cargo install rerun -F web_viewer...
There was a problem hiding this comment.
I would also slow down our own cargo r -p rerun a lot 😭
jprochazk
pushed a commit
that referenced
this pull request
May 11, 2023
This improves compile-times for users that use an external rerun binary. The `rerun` binary, on the other hand, now has `native_viewer` as a _required_ feature. In is an unhappy compromise. Closes #1997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This improves compile-times for users that use an external
rerunbinary. If you want to usespawnorshowyou now have to add thenative_viewerfeature:rerun = { version = "0.6.0", features = ["native_viewer"] }The
rerunbinary, on the other hand, now hasnative_vieweras a required feature.In is an unhappy compromise.
Closes #1997
Checklist
PR Build Summary: https://build.rerun.io/pr/2064