Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In all our Python examples, show how to pip install rerun-sdk #2221

Merged
merged 1 commit into from
May 25, 2023
Merged

In all our Python examples, show how to pip install rerun-sdk #2221

merged 1 commit into from
May 25, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 25, 2023 •
edited by github-actions bot
Loading

What

Changed all our examples from

import rerun as rr

to

import rerun as rr  # pip install rerun-sdk

A lot of people only look at examples, and we want to make sure they don't fall into the trap of pip install rerun

Checklist

PR Build Summary: https://build.rerun.io/pr/2221

@emilk emilk added 📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples labels May 25, 2023
@emilk emilk merged commit 5a1acda into main May 25, 2023
@emilk emilk deleted the emilk/examples-show-pip-install branch May 25, 2023 16:46
emilk added a commit that referenced this pull request May 25, 2023
@emilk
In all our Python examples, show how to pip install rerun-sdk (#2221)
8102df3 
Changed all our examples from

```py
import rerun as rr
```

to

```py
import rerun as rr  # pip install rerun-sdk
```

A lot of people only look at examples, and we want to make sure they
don't fall into the trap of `pip install rerun`

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @jleibs