Migrate to custom checkbox/radio_value UI #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
force-pushed
the
antoine/ui-custom-checkbox
branch
from
238ad94 to
a84686e
Compare
|
cc @martenbjork |
Wumpf
approved these changes
Jul 27, 2023
abey79
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR migrates our checkboxes and radio_values to a custom implementation in
re_ui. Currently, the only change is the removal of the extension effect. In the future, the customisation might go deeper (e.g. custom tick mark, a variant for popup menu, etc.), possibly all the way to copy/pasting and rewriting the entire checkbox code.This PR also introduces a lint to forbid the use of
ui.checkbox()/ui.radio_value().Fixes #2727
Checklist