Fix call to set_recording_id #323
Conversation
| @@ -80,7 +80,7 @@ def set_recording_id(value: str) -> None: | |||
| you will need to manually assign them all the same recording_id. | |||
| Any random UUIDv4 will work, or copy the recording id for the parent process. | |||
| """ | |||
| rerun_sdk.set_recording_id(str) | |||
| rerun_sdk.set_recording_id(value) | |||
There was a problem hiding this comment.
omg, how does mypy not catch this!?
There was a problem hiding this comment.
Pyo3 doesn't (yet) have support for auto-magic generation of a .pyi file so mypy doesn't actually have typing information available to know that set_recording_id doesn't take a type as an input.
We could do this by hand but it's a fair bit of overhead: https://pyo3.rs/v0.16.4/python_typing_hints.html and would still be comparably error prone. The fact that we don't expose our native rust functions directly to end-users means the Python wrappers are effectively where we add our type-hinting information.
In theory pyo3 should have access to most of the information it needs to do this and folks are in fact actively working on making this a reality: PyO3/pyo3#2454
Simple argument error.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)