Replace --strict flag with RERUN_PANIC_ON_WARN env-var
#3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--strict` was an ill-chosen name, as it clashes with the SDK-side strict-modes for user errors. By making it an environment variable it is now also works anywhere `setup_native_logging` is called.
Wumpf
approved these changes
Oct 16, 2023
| // ---------------------------------------------------------------------------- | ||
|
|
||
| #[cfg(not(target_arch = "wasm32"))] | ||
| fn env_var_bool(name: &str) -> Option<bool> { |
There was a problem hiding this comment.
I could swear I've seen this snippet several times over in the codebase, but can't find other instances right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--strictwas an ill-chosen name, as it clashes with the SDK-side strict-modes for user errors.By making it an environment variable it is now also works anywhere
setup_native_loggingis called.Related
Checklist