Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ use nested namespaces for less right shift #4213

Merged
merged 1 commit into from
Nov 13, 2023
Merged

C++ use nested namespaces for less right shift #4213

merged 1 commit into from
Nov 13, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 13, 2023 •
edited by github-actions bot
Loading

What

Changes codegen to use C++17 nested namespaces.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 13, 2023
@Wumpf
Copy link
Member Author

Wumpf commented Nov 13, 2023

Ci is done. The approach was nodded of on Slack. Changes in codegen are trivial. Sounds a like a merge to me!

@Wumpf Wumpf merged commit dcdde90 into main Nov 13, 2023
43 checks passed
@Wumpf Wumpf deleted the andreas/cpp/flat-namespaces branch November 13, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Wumpf