Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Rename rerun::ComponentBatch to rerun::Collection (and related constructs) #4236

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 15, 2023

What

Not much else has changed yet except some doc massaging. First step towards solving

rerun::Collection will evolve from here on and be the corner piece of our zero copy & component adaptability strategy (just like ComponentBatch is already!)

This was originally opened on the wrong branch by accident:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added enhancement New feature or request 🚜 refactor Change the code, not the functionality 🌊 C++ API C/C++ API specific include in changelog labels Nov 15, 2023
@Wumpf
Copy link
Member Author

Wumpf commented Nov 15, 2023

Got already approved as part of the previous PR at #4225 which was further ahead in the git history than it was supposed to.

Just waiting for CI now, then merging

@Wumpf Wumpf merged commit b3f0ff4 into main Nov 15, 2023
83 of 84 checks passed
@Wumpf Wumpf deleted the andreas/cpp/rerun-collection-rename branch November 15, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific enhancement New feature or request include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant