Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples to manifest.yml #4342

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Add more examples to manifest.yml #4342

merged 6 commits into from
Nov 27, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 27, 2023

Adds:

  • Open Photogrammetry Example
  • External C++ VRS example
  • External C++ Eigen/OpenCV exaple

I also opted to sort the examples in lexicographical order because it's in my DNA to do so.

Check the "Examples preview" below

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 27, 2023
@emilk emilk changed the title Add Open Photogrammetry Example to manifest.yml Add Open Photogrammetry Example to manifest.yml Nov 27, 2023
@emilk emilk marked this pull request as draft November 27, 2023 12:31
@emilk emilk changed the title Add Open Photogrammetry Example to manifest.yml Add more examples to manifest.yml Nov 27, 2023
@emilk emilk marked this pull request as ready for review November 27, 2023 13:19
@abey79 abey79 self-requested a review November 27, 2023 13:44
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@emilk emilk merged commit 5174435 into main Nov 27, 2023
40 of 42 checks passed
@emilk emilk deleted the emilk/opf-example branch November 27, 2023 16:02
emilk added a commit that referenced this pull request Nov 27, 2023
* Closes #4315

Adds:
* Open Photogrammetry Example
* External C++ VRS example
* External C++ Eigen/OpenCV exaple

I also opted to sort the examples in lexicographical order because it's
in my DNA to do so.

Check the "Examples preview" below

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4342) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4342)
- [Docs
preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to external C++ examples on examples page
2 participants