-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more examples to manifest.yml
#4342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
examples
Issues relating to the Rerun examples
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Nov 27, 2023
emilk
changed the title
Add Open Photogrammetry Example to manifest.yml
Add Open Photogrammetry Example to Nov 27, 2023
manifest.yml
Part of #4315
emilk
changed the title
Add Open Photogrammetry Example to
Add more examples to Nov 27, 2023
manifest.yml
manifest.yml
abey79
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
emilk
added a commit
that referenced
this pull request
Nov 27, 2023
* Closes #4315 Adds: * Open Photogrammetry Example * External C++ VRS example * External C++ Eigen/OpenCV exaple I also opted to sort the examples in lexicographical order because it's in my DNA to do so. Check the "Examples preview" below ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4342) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4342) - [Docs preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
examples
Issues relating to the Rerun examples
exclude from changelog
PRs with this won't show up in CHANGELOG.md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
I also opted to sort the examples in lexicographical order because it's in my DNA to do so.
Check the "Examples preview" below
Checklist