Resolve unexpected view-partitioning by only bucket images when creating a new 2d view #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
force-pushed
the
jleibs/image_heuristics
branch
from
67705a9 to
17219db
Compare
jleibs
changed the title
jleibs
force-pushed
the
jleibs/image_heuristics
branch
from
17219db to
c996f7d
Compare
abey79
approved these changes
Nov 29, 2023
| @@ -27,6 +27,10 @@ fn is_spatial_class(class: &SpaceViewClassName) -> bool { | |||
| class.as_str() == "3D" || class.as_str() == "2D" | |||
| } | |||
|
|
|||
| fn is_spatial_2d_class(class: &SpaceViewClassName) -> bool { | |||
| class.as_str() == "2D" | |||
There was a problem hiding this comment.
Suggested change
| class.as_str() == "2D" | |
| class.as_str() == SpatialSpaceView2D::NAME |
The function above should follow the same pattern.
There was a problem hiding this comment.
After discussion decided not to make this change since it requires picking up an unwanted dependency -- will refactor away in #4388
teh-cmc
pushed a commit
that referenced
this pull request
Nov 30, 2023
…ing a new 2d view (#4361) ### What - Resolves: #4284 Fixes two issues: - Image bucketing only makes sense for 2d spatial views - The bucket logic would previously trigger even when the aggregate view should have lost out according to the scoring, so we move this into the `should_spawn_new` code-path. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4361) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4361) - [Docs preview](https://rerun.io/preview/c996f7d7a26f19ce3c281e25663d39ed8f8f4016/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/c996f7d7a26f19ce3c281e25663d39ed8f8f4016/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes two issues:
should_spawn_newcode-path.Checklist