-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard input/output support 3: Python SDK stdout impl/examples/docs #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🐍 Python API
Python logging API
🧑💻 dev experience
developer experience (excluding CI)
do-not-merge
Do not merge this PR
include in changelog
labels
Dec 13, 2023
This was referenced Dec 13, 2023
teh-cmc
force-pushed
the
cmc/stdio_2_rust
branch
from
December 13, 2023 19:14
68bdbca
to
52d7156
Compare
teh-cmc
force-pushed
the
cmc/stdio_3_python
branch
from
December 13, 2023 19:16
ccadb17
to
ae18250
Compare
teh-cmc
force-pushed
the
cmc/stdio_2_rust
branch
from
December 13, 2023 19:38
52d7156
to
c80d18b
Compare
teh-cmc
force-pushed
the
cmc/stdio_3_python
branch
from
December 13, 2023 19:39
ae18250
to
954dfe2
Compare
teh-cmc
force-pushed
the
cmc/stdio_2_rust
branch
2 times, most recently
from
December 14, 2023 06:40
98d62d7
to
311322e
Compare
teh-cmc
force-pushed
the
cmc/stdio_3_python
branch
from
December 14, 2023 06:43
954dfe2
to
bcbb76c
Compare
Wumpf
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
teh-cmc
added a commit
that referenced
this pull request
Dec 14, 2023
Add a `stdin` source to the viewer so it can stream data in from standard input. We make `stdin` an explicit input (`rerun -`) like in the good old days, to avoid shady behavior in non-TTY and other esoteric environment (crazy WSL setups, etc). Trust me, it gets quite insane... Checks: - [x] `rerun` works - [x] `rerun -` blocks - [x] `rerun - < data.rrd` works - [x] `cat data.rrd | rerun -` works - [x] `rerun < data.rrd` works but does nothing - [x] `cat data.rrd | rerun` works but does nothing - [x] no-TTY & other esoteric environments don't go completely off the rails --- Part of a small PR series to add stdio streaming support to our Viewer and SDKs: - #4511 - #4512 - #4513 - #4514
teh-cmc
force-pushed
the
cmc/stdio_2_rust
branch
from
December 14, 2023 17:12
0198603
to
0ca0945
Compare
teh-cmc
force-pushed
the
cmc/stdio_3_python
branch
from
December 14, 2023 17:13
81c5d75
to
422f980
Compare
teh-cmc
added a commit
that referenced
this pull request
Dec 14, 2023
…4514) Allow the C++ SDK to stream RRD data to stdout. Checks: - [x] `just py-build && just cpp-build-examples && echo 'hello from stdin!' | ./build/debug/examples/cpp/stdio/example_stdio | rerun -` --- Part of a small PR series to add stdio streaming support to our Viewer and SDKs: - #4511 - #4512 - #4513 - #4514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧑💻 dev experience
developer experience (excluding CI)
include in changelog
🐍 Python API
Python logging API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the Python SDK to stream RRD data to stdout.
Checks:
just py-build && echo 'hello from stdin!' | python examples/python/stdio/main.py | rerun -
Part of a small PR series to add stdio streaming support to our Viewer and SDKs:
Checklist