-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New debug option to show an actual timeline for the Blueprint #4609
Merged
Merged
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0e71c3d
Swap out the whole timeline panel for the blueprint store
jleibs 33d1ce5
Switch blueprint to log with real timepoints
jleibs 2d5e400
Use correct time_ctrl for determining visibillity
jleibs b7e054f
Use correct query for blueprint entities
jleibs 6d075b1
Use the blueprint time_ctrl to drive the blueprint queries
jleibs 810de30
Make the blueprint timeline useful with an option to disable GC
jleibs 3c91af7
Fix rebase for blueprint timepoint
jleibs 7a5e641
Cleanup menu / config options
jleibs 46af2f8
Fix time state updates
jleibs f6902ce
Fix build error in release
jleibs 03416d0
Merge branch 'main' into jleibs/blueprint_timeline
jleibs 9d88924
Make the blueprint inspection panel a secondary timeline panel
jleibs 3b8e773
GC the blueprints more frequently
jleibs 5215ad9
Switch blueprint gc to a radio button
jleibs d773da7
Comment explaining why we can't update the blueprint while we're insp…
jleibs b2a6047
Use re_ui.radio_value
jleibs af8cc5d
Plumb store through data_ui
jleibs 072118b
On the timeline view derive store from the TimePanel source
jleibs c532ed7
More plumbing of queries and stores
jleibs ea96bb2
Limit entity-path store+query guessing to the selection_panel impleme…
jleibs b7a5014
Renames and docstrings
jleibs 23ee728
Merge branch 'main' into jleibs/blueprint_timeline
jleibs 79e395a
Title the blueprint streams accordingly
jleibs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will a tensor entity ever be on the blueprint timeline? I thought that was only applicable to stuff like containers and space view entities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm a bit confused why some
current_query()
has becomecurrent_query_for_entity_path
, but not all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes -- data overrides will be stored in the blueprint. So if you set an override, and then select the blueprint entity representing that override you'll hit this code path.
I scoped my search & replace to the data_ui elements which is the only context in which it should theoretically matter .