Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Cargo.lock in rerun-cli crate #4750

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 9, 2024

This allows users to pass in --locked when installing rerun-cli with cargo-install.

See https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

This allows users to pass in `--locked` when installing `rerun-cli` with `cargo-install`.

See https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile
@emilk emilk added ⛴ release Related to shipping or publishing include in changelog CLI Related to the Rerun CLI labels Jan 9, 2024
@emilk emilk merged commit 0e41edc into main Jan 9, 2024
2 checks passed
@emilk emilk deleted the emilk/add-cargo-lock-to-rerun-cli branch January 9, 2024 14:03
@emilk emilk added this to the 0.12.1 milestone Jan 17, 2024
emilk added a commit that referenced this pull request Jan 17, 2024
This allows users to pass in `--locked` when installing `rerun-cli` with
`cargo-install`.

See
https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs)
<!--DOCS-PREVIEW-->
- [Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Related to the Rerun CLI include in changelog ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants