Fix CMake trying to pick up test folders outside of the Rerun project/zip #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
Wumpf
changed the title
Wumpf
approved these changes
Jan 10, 2024
emilk
pushed a commit
that referenced
this pull request
Jan 17, 2024
…/zip (#4770) ### What This PR changes the `CMakeLists.txt` of `rerun_cpp` to test for the full path of the `tests` directory to avoid false positives. Closes #4769 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4770/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4770/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4770/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4770) - [Docs preview](https://rerun.io/preview/ebe1d4ba438ffd72329b1b50052bc797917208db/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/ebe1d4ba438ffd72329b1b50052bc797917208db/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR changes the
CMakeLists.txtofrerun_cppto test for the full path of thetestsdirectory to avoid false positives.Closes #4769
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io