Replace atty
dependency with std::io::IsTerminal
.
#4790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The
atty
library has a GitHub security advisory noting that it is unmaintained and can be unsound under some conditions. Its functionality can be replaced withstd::io::IsTerminal
; this PR does that.I also added a helper function which replaces the two identical uses; this gives a single place to change the policy if desired, rather than perhaps accidentally editing only one site.
Checklist
I've included a screenshot or gif (if applicable)main
build: app.rerun.ionightly
build: app.rerun.io