External loaders: remove warnings on duplicated binary on $PATH
#4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🧑💻 dev experience
emilk
approved these changes
Jan 17, 2024
| let mut executables = HashMap::<String, Vec<std::path::PathBuf>>::default(); | ||
| for dirpath in dirpaths { | ||
| let paths = WalkDir::new(dirpath) | ||
| .max_depth(1) // don't search recursively |
There was a problem hiding this comment.
At this point you might as well use std::fs::read_dir (less dependencies)
There was a problem hiding this comment.
I removed the use of walkdir in this instance but we still use it for actually recursive walks in other places so cannot get rid of the dependency entirely
teh-cmc
force-pushed
the
cmc/dataloader_keep_first
branch
from
ce5b624 to
596d0a8
Compare
emilk
pushed a commit
that referenced
this pull request
Jan 17, 2024
Keep the first path per unique name, only complain about the others in DEBUG. This makes us behave like any shell and avoids any past, present and future PATH issues that come with Python tools.
emilk
changed the title
$PATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the first path per unique name, only complain about the others in DEBUG.
This makes us behave like any shell and avoids any past, present and future PATH issues that come with Python tools.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io