Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that Mat3x3 and Mat4x4 constructors are column major #4842

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Document that Mat3x3 and Mat4x4 constructors are column major #4842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/mat3x3.hpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/mat3x3_ext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace rerun {
columns[2].z(),
} {}

/// Construct a new 3x3 matrix from a pointer to 9 floats (in row major order).
/// Construct a new 3x3 matrix from a pointer to 9 floats (in column major order).
explicit Mat3x3(const float* elements)
: flat_columns{
elements[0],
Expand Down
2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/mat4x4.hpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/mat4x4_ext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace rerun {
columns[3].w(),
} {}

/// Construct a new 4x4 matrix from a pointer to 16 floats (in row major order).
/// Construct a new 4x4 matrix from a pointer to 16 floats (in column major order).
explicit Mat4x4(const float* elements)
: flat_columns{
elements[0],
Expand Down
Loading