Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++ arrow build flag forwarding #4921

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix C++ arrow build flag forwarding #4921

merged 1 commit into from
Jan 26, 2024

Conversation

rgolovanov
Copy link
Contributor

@rgolovanov rgolovanov commented Jan 26, 2024 •
edited by github-actions bot
Loading

Proper use of some parameters:

  • ARROW_ASAN - shall be used instead of RERUN_USE_ASAN because otherwise the property isn't set in MSVC configuration
  • ARROW_CXXFLAGS - there was a typo with unnecessary D in the beginning

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@rgolovanov
Update download_and_build_arrow.cmake
6d48983 
Proper use of some parameters:
* ARROW_ASAN - shall be used instead of RERUN_USE_ASAN because otherwise the property isn't set in MSVC configuration
* ARROW_CXXFLAGS - there was a typo with unnecessary D in the beginning
@Wumpf Wumpf changed the title Fix some typos in CMake parameters Fix C++ arrow build flag forwarding Jan 26, 2024
@Wumpf Wumpf added 🏹 arrow concerning arrow 🌊 C++ API C/C++ API specific include in changelog labels Jan 26, 2024
Wumpf
Wumpf approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you again!
calling this just a typo-fix is underselling it, this was legitimately broken before

@Wumpf Wumpf merged commit acd699c into rerun-io:main Jan 26, 2024
5 of 8 checks passed
@rgolovanov
Copy link
Contributor Author

Yes, it should speed up compilation of Arrow with MSVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🏹 arrow concerning arrow 🌊 C++ API C/C++ API specific include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgolovanov @Wumpf