Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "+" icon from the "Add SV/Container" modal and close on click #4927

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jan 29, 2024

What

This PR introduces two minor tweaks to the "Add Space View or Container" modal:

  • remove the big "+" button
  • close the modal on click
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jan 29, 2024
@nikolausWest
Copy link
Member

nikolausWest commented Jan 29, 2024

Nice! One more small one (mentioned on the same ticket as these):

  • select the newly created container or space view

Brownie points:

  • Preview with the same (viz as when dragging) where the thing will be created (when the modal is open)

Note: both of these can go in other PRs at another time but thought I'd mention them here since this PR doesn't reference an issue

@abey79
Copy link
Member Author

abey79 commented Jan 29, 2024

Nice! One more small one (mentioned on the same ticket as these):

  • select the newly created container or space view

Brownie points:

  • Preview with the same (viz as when dragging) where the thing will be created (when the modal is open)

Note: both of these can go in other PRs at another time but thought I'd mention them here since this PR doesn't reference an issue

I'll do the selecting one soon, but in a different PR because it touches some other places.

As for the preview one, I've added to the todo list. This one is a bit more evolve and requires some work to support a "temporary/preview viewport" in our code. I'll add that topic to the current cycle.

@nikolausWest
Copy link
Member

As for the preview one, I've added to the todo list. This one is a bit more evolve and requires some work to support a "temporary/preview viewport" in our code. I'll add that topic to the current cycle.

I should have clarified that I primarily meant previewing in the blueprint tree but I think it's a good idea to preview everywhere in a unified manner

@abey79
Copy link
Member Author

abey79 commented Jan 29, 2024

As for the preview one, I've added to the todo list. This one is a bit more evolve and requires some work to support a "temporary/preview viewport" in our code. I'll add that topic to the current cycle.

I should have clarified that I primarily meant previewing in the blueprint tree but I think it's a good idea to preview everywhere in a unified manner

Oh ok—useful clarification 👍🏻

@abey79 abey79 merged commit c2688ad into main Jan 30, 2024
42 of 43 checks passed
@abey79 abey79 deleted the antoine/add-sv-modal-no-plus branch January 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants