Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for very large meshes & plots by always picking the largest available GPU buffer size #5053

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Allow for very large meshes & plots by always picking the largest available GPU buffer size #5053

merged 2 commits into from
Feb 6, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 6, 2024 •
edited
Loading

What

We already did this for textures, was overdue to do it for buffers as well.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

teh-cmc
teh-cmc approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on my end -- I can now look at 4M non-aggregated points on a plot 😱

@Wumpf Wumpf added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself 💣 crash crash, deadlock/freeze, do-no-start include in changelog labels Feb 6, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Feb 6, 2024

@nikolausWest confirmed as well

@Wumpf Wumpf merged commit 3a348f8 into main Feb 6, 2024
43 of 45 checks passed
@Wumpf Wumpf deleted the andreas/no-buffer-limit branch February 6, 2024 10:12
@teh-cmc teh-cmc changed the title Fix handling very large meshes & plots (allow maximum available gpu buffers) Allow for very large meshes & plots by always picking the largest available GPU buffer size Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start include in changelog 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on un-aggregated SeriesPoint for 1M series Crash when supplying too large mesh
2 participants
@Wumpf @teh-cmc