Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forever repaint of big scenes #5071

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fix forever repaint of big scenes #5071

merged 2 commits into from
Feb 6, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 6, 2024

What

When first loading a scene, before the user interacts, we want to center the eye-camera on the scene, so each frame we call "interpolate to the default eye". This should be fine, because we have an early-out if we're already at target. However, the interpolation code had a rounding error meaning we reached very close to our goal, but not quite there. In particular, in arkit_scenes it would lead to a forever repaint, since the eye-camera would never reach its target, and so thus would require more animation.

This manifested in arkit_scenes now due to another bug (#5070) causing enormous point clouds, making the rounding errors larger than usual.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 6, 2024
@emilk emilk changed the title Fix forever repaint Fix forever repaint of big scenes Feb 6, 2024
@emilk emilk added include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 6, 2024
@emilk emilk merged commit 74d918d into main Feb 6, 2024
45 of 49 checks passed
@emilk emilk deleted the emilk/forever-repaint branch February 6, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless ui refresh
2 participants