Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached 2D & 3D line clouds #5083

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Cached 2D & 3D line clouds #5083

merged 2 commits into from
Feb 7, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 7, 2024 •
edited
Loading

Grunt work to make line clouds go through the cached APIs.

Perf comparison using @abey79 's dataset

main:
image

now:
image

TODO:

  • self-review
  • check doc examples still work
    • line_segments2d_simple
    • line_segments3d_simple
    • line_strip2d_batch
    • line_strip2d_simple
    • line_strip3d_batch
    • line_strip3d_simple
  • perf comparison with Antoine's dataset

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added 🔍 re_query affects re_query itself 🚀 performance Optimization, memory use, etc include in changelog labels Feb 7, 2024
@teh-cmc teh-cmc marked this pull request as ready for review February 7, 2024 10:47
@Wumpf Wumpf self-requested a review February 7, 2024 13:37
Wumpf
Wumpf approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neato!

@Wumpf Wumpf merged commit fccd095 into main Feb 7, 2024
44 of 53 checks passed
@Wumpf Wumpf deleted the cmc/lines_and_arrows branch February 7, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🚀 performance Optimization, memory use, etc 🔍 re_query affects re_query itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf