Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark TimeSeriesScalar as deprecated in all SDKs and documentation #5102

Merged
merged 15 commits into from
Feb 8, 2024
Merged

Mark TimeSeriesScalar as deprecated in all SDKs and documentation #5102

merged 15 commits into from
Feb 8, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 7, 2024 •
edited by github-actions bot
Loading

What

Our codegen can now deprecate archetypes

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Feb 7, 2024
@teh-cmc teh-cmc self-requested a review February 7, 2024 16:13
teh-cmc
teh-cmc approved these changes Feb 7, 2024
View reviewed changes
crates/re_types/src/archetypes/mod.rs Outdated Show resolved Hide resolved
@Wumpf
Copy link
Member Author

Wumpf commented Feb 7, 2024

just noticed a few more places in the docs that should show (deprecated)

@teh-cmc teh-cmc linked an issue Feb 7, 2024 that may be closed by this pull request
Handle builtin deprecated fbs attribute #2366
Closed
@teh-cmc
Copy link
Member

teh-cmc commented Feb 7, 2024

emilk
emilk approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to have this in!

crates/re_types/definitions/rerun/attributes.fbs Outdated Show resolved Hide resolved
tests/python/chroma_downsample_image/requirements.txt Outdated Show resolved Hide resolved
jleibs
jleibs reviewed Feb 7, 2024
View reviewed changes
pixi.toml Show resolved Hide resolved
@Wumpf Wumpf merged commit 52461cc into main Feb 8, 2024
43 checks passed
@Wumpf Wumpf deleted the andreas/codegen-deprecation branch February 8, 2024 08:16
@teh-cmc teh-cmc changed the title Mark TimeSeriesScalar as deprecated in all SDKs and documentation Mark TimeSeriesScalar as deprecated in all SDKs and documentation Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs left review comments

@teh-cmc teh-cmc teh-cmc approved these changes

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages
Projects
None yet
Milestone
No milestone
4 participants
@Wumpf @teh-cmc @emilk @jleibs