-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context menu 3: add "Move to new container" context menu action #5210
Conversation
It is a bit weird that the context menu shows options that will end up doing nothing (e.g. |
Yeah, that's a matter of choice. The alternative I considered is to disable entirely the context menu whenever the selection is "root container + something", because none of the operations that applies to multiple hierarchy thing can be applied to the root container (visibility, remove, move to new container). None of these seem ideal to me though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again discovered many things I didn't know about 🤯
Two issues there:
|
d3dfd4e
to
cf1cd55
Compare
What
This PR adds a new "Move to new container" context menu action, that applies when one or more space views and/or containers are selected. The new container is created at the location of the clicked item, and all the selected items are moved into it.
Note: one very often runs into this while using this feature:
TODO in future PR:
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io