Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable path parts in selection-panel #5220

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Clickable path parts in selection-panel #5220

merged 2 commits into from
Feb 19, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 16, 2024

UPDATE: Cleaned it up with @abey79!

Just a proof-of-concept as I have no clue how to do things correctly and no time to dig right now.

But UX wise, man, it's awesome!

24-02-16_17.44.23.patched.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added ui concerns graphical user interface do-not-merge Do not merge this PR include in changelog labels Feb 16, 2024
@teh-cmc teh-cmc force-pushed the cmc/clickable_parts branch from c66fc37 to 45766c5 Compare February 18, 2024 16:45
- added path to parent entity in the top-level context
- removed redundant blueprint section for non-splat instance
- adjusted spacing in `{instance|entity_path}_parts_button`
@teh-cmc teh-cmc changed the title Proof of concept: clickable path parts in selection-panel Clickable path parts in selection-panel Feb 19, 2024
@teh-cmc teh-cmc marked this pull request as ready for review February 19, 2024 15:01
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Feb 19, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Feb 19, 2024

Reviewed irl with @abey79

@teh-cmc teh-cmc merged commit 46d6854 into main Feb 19, 2024
42 of 43 checks passed
@teh-cmc teh-cmc deleted the cmc/clickable_parts branch February 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants