Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ugly UI for some arrow data #5235

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Fix ugly UI for some arrow data #5235

merged 5 commits into from
Feb 20, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 20, 2024

What

Improve the display of arbitrary arrow data, slightly.

There were several problems:

  • We were displaying huge datatypes (unions)
  • We were not respecting the max toolbar size
  • We were falling back on datatype too early

Before:
Screenshot 2024-02-20 at 10 46 21

After:
Screenshot 2024-02-20 at 10 46 02

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog labels Feb 20, 2024
@emilk emilk merged commit 285d1fe into main Feb 20, 2024
44 checks passed
@emilk emilk deleted the emilk/shorter-arrow-tooltip branch February 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants