Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing redraw upon resetting blueprint #5262

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 23, 2024

What

Previously, many parts of the viewer only refresh after moving the cursor. Just clicking the reset button and not moving the mouse left things in an odd state.

Can't screenshot since pressing the screenshot shortcut causes a redraw :)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

Previously, many parts of the viewer only refresh after moving the cursor. Just clicking the reset button and not moving the mouse left things in an odd state
@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Feb 23, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egui actually does two repaints for each event (or in other words: repaints until one frame has no new input), so I'm a bit surprised this is needed 🤔 Is there two frames of latency somehow?

@Wumpf
Copy link
Member Author

Wumpf commented Feb 23, 2024

Hum, that's quite odd then, yes!

@Wumpf Wumpf merged commit 2c12192 into main Feb 23, 2024
4 checks passed
@Wumpf Wumpf deleted the andreas/fix-missing-redraw-on-reset branch February 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants