Only compute store/caching stats when the memory panel is opened #5274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing stats for the store and caches is a very costly process.
We do so every frame because the memory panel's data gets updated whether it is opened or not, so that the memory graphs are not missing any data when you eventually open it.
In the case of the store, we've added a lot of complexity a long time ago to make that process fast enough (although in a big enough scene, it will still take a non-trivial amount of time).
I've recently gone through the process of adding the same kind of complexity to the caches, but it gets absolutely insane -- so insane that it's just not worth it.
So, instead of making the caches even more complicated than they already are just so the memory panel can get updated in the background, we've decided to just not updated the mempanel stats when it's hidden.
Before:
After (mempanel opened):
After (mempanel hidden):
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io