-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different icon for empty entity paths #5338
Conversation
@nikolausWest good spot! These are an oversight from my previous PR. Will fix asap. edit: #5341 |
crates/re_time_panel/src/lib.rs
Outdated
.with_icon(if tree.entity.components.is_empty() { | ||
&re_ui::icons::ENTITY_EMPTY | ||
} else { | ||
&re_ui::icons::ENTITY | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an inconsistency here: the data UI uses DataStore::all_components
which is timeful, while this uses the EntityTree
which is timeless.
I.e. scrubbing the time cursor might change the icon that appears in the blueprint panel and elsewhere, while that won't happen in the time panel.
I think that's fine (unless we want both to be timeless), but deserves a comment to specify that this was intentional at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, both were actually timeless, but instance_path_icon()
accepting a Query
argument was very confusing. I changed it to accept a Timeline
instead, which is all it needs.
Also, I made both the streams and the blueprint have their icons based on the current timeline (in my original commit, the streams icon was based on all timeline).
nice! |
# Conflicts: # crates/re_viewer/src/ui/selection_panel.rs
What
This PR adds a subtly different icon for "empty" entities. By "empty", I mean "no component logged on the current timeline". This means that changing timeline may potentially change the icon of some entity (though it takes a somewhat contrived example to do so).
TODO:
Fixes #5302
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io