Add an explicit DataResult
variant to re_viewport_context::Item
#5369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Basically this:
The motivation is to make the distinction between an entity/instance from the data store distinct from an entity/instance in the context of a space view query's data result.
Note: I initially considered having an
InstancePath
instead of anEntityPath
forItem::DataResult
. However, after discussing with @Wumpf, we deemed that undesirable as we want to be able to select (or otherwise consider) single instances from data results.This PR also fixes a very subtle usability fix whereby clicking on the
shown
button in the selection panel for a data store instance would lead to the corresponding space view data result entity (not instance!). This is fixed now.Checklist
main
build: app.rerun.ionightly
build: app.rerun.io