Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uuid & IncludedSpaceView types are now serializable in python #5372

Merged
merged 9 commits into from
Mar 4, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 1, 2024

What

Steps towards serializable ViewportBlueprint. Adjusted structure a bit: it used to be IncludedSpaceViews (plural) it's now IncludedSpaceView (singular) and we store a component array on the `ViewportBlueprint archetype.
Also, uuid needed some extra love on codegen as well.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🐍 Python API Python logging API 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 1, 2024
@teh-cmc teh-cmc self-requested a review March 4, 2024 08:01
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the data model change but other than that lgtm

@Wumpf Wumpf merged commit 236599f into main Mar 4, 2024
39 checks passed
@Wumpf Wumpf deleted the andreas/serializable-included-space-view branch March 4, 2024 13:21
@Wumpf Wumpf mentioned this pull request Mar 4, 2024
5 tasks
Wumpf added a commit that referenced this pull request Mar 5, 2024
### What

* direct followup to #5372
* part of #4167

--

* necessary massaging to get the rest of `ViewportBlueprint` to
serialize out of python
* finished up related unit test
* remove `ViewportLayout`
* unify blueprint component write helpers a bit


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5385/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5385/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5385/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5385)
- [Docs
preview](https://rerun.io/preview/a5f40715a5006839a0bebdacb87485bb5c349d4d/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/a5f40715a5006839a0bebdacb87485bb5c349d4d/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants