CMake: Fix install
not finding external arrow
for dynamic linking
#5375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if
rerun_sdk
was build withRERUN_DOWNLOAD_AND_BUILD_ARROW
set toOFF
andRERUN_ARROW_LINK_SHARED
set toON
, the downstream build of a package that usesrerun_sdk
viafind_package(rerun_sdk)
had the following problems:Arrow::arrow_static
(as it is the case for conda-forge, at least for thelibarrow
package), the CMake failed as the non-existentArrow::arrow_static
target was referenced.These two problems are solved in these PR by:
@RERUN_DOWNLOAD_AND_BUILD_ARROW@
is OFFrerun_arrow_target
target using the value ofRERUN_ARROW_LINK_SHARED
used when building rerun.What
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io