All python components that wrap a bool now implement __bool__
#5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
reviewed
Mar 5, 2024
| @@ -633,6 +633,20 @@ fn code_for_struct( | |||
| code.push_indented(1, quote_init_method(reporter, obj, ext_class, objects), 2); | |||
| } | |||
|
|
|||
| // Generate __bool__ operator if this is a single field struct with a bool field. | |||
| if fields.len() == 1 && fields[0].typ == Type::Bool { | |||
There was a problem hiding this comment.
I don't know if we have to restrict this to bool.
Definitely not as critical as the bool case, but for types that contain an int, for example, it would be nice to have 0 act Falsey as well.
emilk
changed the title
__bool__
emilk
changed the title
__bool__bool now implement __bool__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes unexpected errors with python truthiness.
plus some mypy linting fixes for issues I encountered when running
pixi run lint-py-mypyon windowsChecklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io