Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpaceViewBlueprint is now python serializable #5401

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 5, 2024

What

Plus the usual amount of plumbing, following overall similar patterns than the previous PRs in this area

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 5, 2024


class VisibleExt:
"""Extension for [Visible][rerun.components.Visible]."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to get fixed in merge.

contents_arrays = [[uuid_bytes0, uuid_bytes1], [IncludedQuery(uuid_bytes0), IncludedQuery(uuid_bytes1)], None]
visible_arrays = [False, Visible(False), None]

all_arrays = itertools.zip_longest(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, zip_longest appears to lead to mypy lint errors. In my PR I had to add:

        container_kind = cast(ContainerKindLike, container_kind)
        display_name = cast(Optional[Utf8Like], display_name)
        contents = cast(Optional[EntityPathArrayLike], contents)
        col_shares = cast(Optional[ColumnShareArrayLike], col_shares)
        row_shares = cast(Optional[RowShareArrayLike], row_shares)
        active_tab = cast(Optional[EntityPathLike], active_tab)
        visible = cast(Optional[VisibleLike], visible)
        grid_columns = cast(Optional[GridColumnsLike], grid_columns)

to fix it 😭

@jleibs jleibs force-pushed the andreas/serializable-spaceviewblueprint branch 2 times, most recently from af1733e to 4095985 Compare March 5, 2024 22:00
@jleibs jleibs merged commit 203730d into main Mar 5, 2024
39 checks passed
@jleibs jleibs deleted the andreas/serializable-spaceviewblueprint branch March 5, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants