-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New timezone option: seconds since unix epoch #5450
Conversation
|
yup, that is already implemented, basically for unix epoch display everywhere there was a whole second in the format i show unix epoch instead - but if there is a time display with no seconds shown (on a whole minute) I don't know which would be better: Also another question, should I label pull request myself with include/exclude in changelog? Or is that something maintainers do? |
I think that if the user has selected the option for "seconds since unix epoch", we should always use seconds, everywhere - no minutes or hours. As for labels: only maintainers can add labels. I haven't found any GitHub option to allow contributors to add labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great - thanks for the PR!
What
Added a unix epoch timestamp display option, as mentioned in issue 4866
Not quite sure how compact time display should be handled:
Should the
[hour]:[minute]
be changed as well when unix timestamp is chosen?Checklist
main
build: app.rerun.ionightly
build: app.rerun.io