Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for active_tab #5499

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add support for active_tab #5499

merged 2 commits into from
Mar 14, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 13, 2024

What

Referring to an object created in the same constructor is somewhat awkward.

Forcing users to create the object out-of-line so they can assign it to a variable and then refer to it is just a pain.
Specifying a name or index seems like a convenient middle ground.

Example

            Tabs(
                BarChartView(name="Bar Chart", origin="/bar_chart", contents=["/bar_chart/**"]),
                TimeSeriesView(name="Curves", origin="/curves", contents=["/curves/**"]),
                TimeSeriesView(name="Trig", origin="/trig", contents=["/trig/**"]),
                TimeSeriesView(name="Classification", origin="/classification", contents=["/classification/**"]),
                active_tab="Curves",
            ),

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jleibs jleibs added 🟦 blueprint The data that defines our UI 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 13, 2024
@jleibs jleibs marked this pull request as ready for review March 13, 2024 21:48
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Base automatically changed from jleibs/more_space_views to main March 14, 2024 15:16
@jleibs jleibs force-pushed the jleibs/active_tab branch from 4633c9b to 4c45a10 Compare March 14, 2024 15:18
### What
Just a bit of additional argument plumbing

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5509/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5509/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5509/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5509)
- [Docs
preview](https://rerun.io/preview/7ee38659a212a38b70ab47ee81755c6352c43ad2/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7ee38659a212a38b70ab47ee81755c6352c43ad2/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf Wumpf merged commit 9977717 into main Mar 14, 2024
20 of 23 checks passed
@Wumpf Wumpf deleted the jleibs/active_tab branch March 14, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants