-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading .rbl
blueprint files
#5513
Conversation
.bpl
blueprint files.rbl
blueprint files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to merging as is out of expediency, but as noted, this introduces an issue when using blueprints with connect, especially on recordings that stream for longer amounts of time.
crates/re_viewer/src/app.rs
Outdated
store_hub.set_blueprint_for_app_id( | ||
entity_db.store_id().clone(), | ||
store_info.application_id.clone(), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is definitely an improvement for the file-open use-case, moving this here regresses the current blueprint-on-connect behavior.
Because blueprint and recording share the same channel, the blueprint now won't be activated until the channel is closed.
You can see this issue by adding:
import time
time.sleep(5)
to the end of examples/python/blueprint/main.py
This causes the saved blueprint to load first. And then after the timeout when the whole connection is closed, the blueprint loads.
This alone is insufficient for #5297... we still need some kind of safe-to-load marker inside the stream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch; good point…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I might merge this and then start work on #5297
.rbl
blueprint files.rbl
blueprint files
.rbl
blueprint files.bpl
blueprint files
Size changes
|
.bpl
blueprint files.rbl
blueprint files
What
This implements loading of blueprint files (.rbl) on native and on web, using either drag-and-drop of the
Open…
command.One shortcoming of the approach in this PR is documented here:
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io