Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading .rbl blueprint files #5513

Merged
merged 14 commits into from
Mar 15, 2024
Merged

Support loading .rbl blueprint files #5513

merged 14 commits into from
Mar 15, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 14, 2024

What

This implements loading of blueprint files (.rbl) on native and on web, using either drag-and-drop of the Open… command.

One shortcoming of the approach in this PR is documented here:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 📺 re_viewer affects re_viewer itself 🟦 blueprint The data that defines our UI include in changelog labels Mar 14, 2024
@emilk emilk marked this pull request as ready for review March 14, 2024 18:04
@emilk emilk changed the title Support drag-drop loading of .bpl blueprint files Support drag-drop loading of .rbl blueprint files Mar 14, 2024
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to merging as is out of expediency, but as noted, this introduces an issue when using blueprints with connect, especially on recordings that stream for longer amounts of time.

Comment on lines 960 to 963
store_hub.set_blueprint_for_app_id(
entity_db.store_id().clone(),
store_info.application_id.clone(),
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is definitely an improvement for the file-open use-case, moving this here regresses the current blueprint-on-connect behavior.

Because blueprint and recording share the same channel, the blueprint now won't be activated until the channel is closed.

You can see this issue by adding:

import time
time.sleep(5)

to the end of examples/python/blueprint/main.py

This causes the saved blueprint to load first. And then after the timeout when the whole connection is closed, the blueprint loads.

This alone is insufficient for #5297... we still need some kind of safe-to-load marker inside the stream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch; good point…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I might merge this and then start work on #5297

@emilk emilk changed the title Support drag-drop loading of .rbl blueprint files Support loading of .rbl blueprint files Mar 15, 2024
@emilk emilk changed the title Support loading of .rbl blueprint files Support loading .bpl blueprint files Mar 15, 2024
Copy link

Size changes

Name main 5513/merge Change
arkit_scenes.rrd 39.43 MiB 40.34 MiB +2.31%

@emilk emilk merged commit a79520e into main Mar 15, 2024
34 checks passed
@emilk emilk deleted the emilk/load-rbl branch March 15, 2024 09:24
@emilk emilk changed the title Support loading .bpl blueprint files Support loading .rbl blueprint files Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants