Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the names of the links in types.md #5526

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix the names of the links in types.md #5526

merged 1 commit into from
Mar 15, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 15, 2024 •
edited by github-actions bot
Loading

What

Some names that never got updated.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jleibs jleibs added 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md 📖 documentation Improvements or additions to documentation and removed 🟦 blueprint The data that defines our UI labels Mar 15, 2024
@jleibs jleibs marked this pull request as ready for review March 15, 2024 11:53
jleibs
jleibs commented Mar 15, 2024
View reviewed changes
docs/content/reference/types.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess one of our prettifiers wanted this formatted differently? 🤷‍♂️

@jleibs jleibs merged commit 1509aae into main Mar 15, 2024
35 of 36 checks passed
@jleibs jleibs deleted the jleibs/type_link_names branch March 15, 2024 14:24
@teh-cmc
Copy link
Member

teh-cmc commented Mar 15, 2024

Hmmm... That very much looks like a page that should be generated though...

@teh-cmc teh-cmc mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleibs @teh-cmc