Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme of depth_guided_stable_diffusion example #5593

Merged
merged 17 commits into from
Apr 4, 2024

Conversation

BirgerMoell
Copy link
Contributor

@BirgerMoell BirgerMoell commented Mar 20, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@BirgerMoell BirgerMoell added the 📖 documentation Improvements or additions to documentation label Mar 20, 2024
@emilk emilk changed the title Clean pull request for #5502 Improve readme of depth_guided_stable_diffusion example Mar 20, 2024
@Wumpf
Copy link
Member

Wumpf commented Mar 20, 2024

I pushed a blueprint for this example earlier today, so this has now a slight merge conflict with that.

Copy link

Size changes

Name main 5593/merge Change
re_sdk --no-default-features 117 crates 111 crates -6 crates

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's some deeper conflicts with the blueprint that landed by now for this example that need to be reconciled.

Readme reads well overall but more as a general observation I'm missing on a bunch of things why it would be useful to look at some of the data in particular. Don't think it makes sense to point that out everywhere in detail, but I think it would be nice to point out some of the ways it can be helpful to see what's going on and how one could react to that 🤔. Might be more applicable to other examples

@BirgerMoell BirgerMoell force-pushed the new-depth-guided-stable-diffusion branch from e404de2 to 93f78c2 Compare April 3, 2024 08:38
@Wumpf Wumpf merged commit eb1892e into main Apr 4, 2024
31 checks passed
@Wumpf Wumpf deleted the new-depth-guided-stable-diffusion branch April 4, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants