Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New standalone example showing blueprint configuration of some stock #5603

Merged
merged 16 commits into from
Mar 21, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 20, 2024

What

This is the example that the blueprint getting started guide / tutorials will be built off of.

However, this is a slightly more full-featured example that can be used as a reference and standalone application.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jleibs jleibs added examples Issues relating to the Rerun examples 🟦 blueprint The data that defines our UI include in changelog labels Mar 20, 2024
@jleibs jleibs marked this pull request as ready for review March 20, 2024 17:18
Copy link

github-actions bot commented Mar 20, 2024

Size changes

Name main 5603/merge Change
rrt-star.rrd 9.13 MiB 6.59 MiB -27.82%

@jleibs jleibs force-pushed the jleibs/blueprint_stocks branch from 702af1c to 75add53 Compare March 20, 2024 19:41
@jleibs jleibs force-pushed the jleibs/blueprint_stocks branch from bf8a6b0 to 4563b48 Compare March 20, 2024 22:07
@teh-cmc teh-cmc self-requested a review March 21, 2024 08:11
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real nice

examples/python/blueprint_stocks/main.py Outdated Show resolved Hide resolved
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool example, but the requirements.txt is causing me issues

examples/python/blueprint_stocks/requirements.txt Outdated Show resolved Hide resolved
Comment on lines +31 to +38
Available choices are:

- `auto`: Reset the blueprint to the auto layout used by the viewer.
- `one-stock`: Uses a filter to show only a single chart.
- `one-stock-with-info`: Uses a container to layout a chart and its info document
- `one-stock-no-peaks`: Uses a filter to additionally remove some of the data from the chart.
- `compare-two`: Adds data from multiple sources to a single chart.
- `grid`: Shows all the charts in a grid layout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to give them different application ids each: Right now it's quite confusing when you just leave the viewer open and try to execute the script several times with different blueprints :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed on slack, no immediate action to take. We know that application id changing is more wrong. Comes down to figuring out the blueprint lifecycle

examples/python/blueprint_stocks/main.py Outdated Show resolved Hide resolved
rerun_py/rerun_sdk/rerun/blueprint/__init__.py Outdated Show resolved Hide resolved
@jleibs jleibs merged commit db27962 into main Mar 21, 2024
34 checks passed
@jleibs jleibs deleted the jleibs/blueprint_stocks branch March 21, 2024 17:38
@jleibs jleibs restored the jleibs/blueprint_stocks branch May 9, 2024 18:43
@jleibs jleibs deleted the jleibs/blueprint_stocks branch May 9, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI examples Issues relating to the Rerun examples include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants