Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated READMEs for the examples - Batch 1 #5620

Merged
merged 17 commits into from
Apr 4, 2024
Merged

Updated READMEs for the examples - Batch 1 #5620

merged 17 commits into from
Apr 4, 2024

Conversation

andreasnaoum
Copy link
Contributor

@andreasnaoum andreasnaoum commented Mar 21, 2024 •
edited by github-actions bot
Loading

Updated READMEs for the examples:
Detect and Track Objects
Dicom MRI
Face Tracking
Gesture Detection
Human Pose Tracking
LiDAR
Live Camera Edge Detection
Live Depth Sensor

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@andreasnaoum andreasnaoum changed the title Updated READMEs for the examples Detect and Track Objects, Dicom MRI, Face Tracking, Gesture Detection, Human Pose Tracking, LiDAR Updated READMEs for the examples Detect and Track Objects, Dicom MRI, Face Tracking, Gesture Detection, Human Pose Tracking, LiDAR, Live Camera Edge Detection, Live Depth Sensor Mar 21, 2024
@andreasnaoum andreasnaoum added 📖 documentation Improvements or additions to documentation ui concerns graphical user interface examples Issues relating to the Rerun examples labels Mar 21, 2024
@andreasnaoum andreasnaoum mentioned this pull request Mar 21, 2024
Open
2 tasks
@emilk
Copy link
Member

emilk commented Mar 21, 2024

Tip: configure your editor to trim trailing newlines. See https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md#tools for more :)

image

This was referenced Mar 25, 2024
Closed
Open
nikolausWest and others added 3 commits March 28, 2024 19:16
@nikolausWest @emilk
.... -> …
2270f09 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@nikolausWest @emilk
newline
aadf699 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@nikolausWest @emilk
... -> …
185cfaa 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
nikolausWest
nikolausWest previously requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@nikolausWest nikolausWest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These also all need background sections

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

Size changes

Name main 5620/merge Change
rrt-star.rrd 10.0 MiB (deleted) -100%

@andreasnaoum andreasnaoum changed the title Updated READMEs for the examples Detect and Track Objects, Dicom MRI, Face Tracking, Gesture Detection, Human Pose Tracking, LiDAR, Live Camera Edge Detection, Live Depth Sensor Updated READMEs for the examples - Batch 1 Apr 4, 2024
@andreasnaoum andreasnaoum self-assigned this Apr 4, 2024
@andreasnaoum
Copy link
Contributor Author

Background sections added, should we merge this request?

Wumpf
Wumpf approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background sections lgtm

@Wumpf Wumpf merged commit 6de5e14 into main Apr 4, 2024
31 checks passed
@Wumpf Wumpf deleted the andreasnaoum-example-readmes-batch1 branch April 4, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roym899 roym899 roym899 left review comments

@Wumpf Wumpf Wumpf approved these changes

@emilk emilk emilk left review comments

@nikolausWest nikolausWest nikolausWest left review comments

Assignees

@andreasnaoum andreasnaoum

Labels
📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreasnaoum @emilk @Wumpf @nikolausWest @roym899