Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blueprint to Signed Distance Fields example #5635

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Add blueprint to Signed Distance Fields example #5635

merged 5 commits into from
Mar 22, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 21, 2024 •
edited by github-actions bot
Loading

What

Also replace the somewhat broken screenshot it had (thumbnail was alright)

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added examples Issues relating to the Rerun examples include in changelog labels Mar 21, 2024
@Wumpf Wumpf mentioned this pull request Mar 21, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

Size changes

Name main 5635/merge Change
rrt-star.rrd 29.44 MiB 5.53 MiB -81.22%

@teh-cmc teh-cmc self-requested a review March 22, 2024 07:32
teh-cmc
teh-cmc approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Looks like you inadvertently added a submodule though

src/mesh-to-sdf Outdated Show resolved Hide resolved
teh-cmc
teh-cmc reviewed Mar 22, 2024
View reviewed changes
examples/python/signed_distance_fields/README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see any reason why this example isnt available in the app? We should add a channel here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One reason is that is quite confusing. I think a README would be a pre-requisite for adding it to the app. Maybe also make it a bit prettier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not doing that in this pr

@Wumpf
Copy link
Member Author

Wumpf commented Mar 22, 2024

Looks like you inadvertently added a submodule though

urgh, thought I removed that again, wasn't thorough. The requirements.txt in this one does a clone which an innocent git add . will trip over then

@Wumpf Wumpf force-pushed the andreas/sdf-blueprint branch from 9c20aa1 to 2d6611e Compare March 22, 2024 09:07
@Wumpf Wumpf merged commit 7bfe1bd into main Mar 22, 2024
31 checks passed
@Wumpf Wumpf deleted the andreas/sdf-blueprint branch March 22, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

@emilk emilk emilk left review comments

Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wumpf @emilk @teh-cmc