Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity path query now shows simple statistics and warns if nothing is displayed #5693

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 26, 2024

What

Screen.Recording.2024-03-26.at.18.56.09.mov

a small step towards making it easy to debug why no data might be shown

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🟦 blueprint The data that defines our UI include in changelog labels Mar 26, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

crates/re_viewer/src/ui/selection_panel.rs Outdated Show resolved Hide resolved
if query.num_matching_entities != 0 && query.num_visualized_entities == 0 {
// TODO(andreas): Talk about this root bit only if it's a spatial view.
ui.label(ctx.re_ui.warning_text(
format!("This space view is not able to visualize any of the matched entities using the current root \"{origin:?}\"."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably use a tooltip that explains it more in detail

@emilk emilk self-assigned this Mar 27, 2024
@emilk emilk merged commit a1f59db into main Mar 27, 2024
34 checks passed
@emilk emilk deleted the andreas/simple-query-stats branch March 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple static description of why a space view is empty.
2 participants