Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web viewer links #5738

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Update web viewer links #5738

merged 6 commits into from
Apr 2, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Apr 2, 2024

What

Update most web viewer links from app.rerun.io to rerun.io/viewer.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jprochazk jprochazk added 📖 documentation Improvements or additions to documentation 🕸️ web regarding running the viewer in a browser include in changelog labels Apr 2, 2024
@emilk
Copy link
Member

emilk commented Apr 2, 2024

"most"? Which ones aren't updated, and why?

.vscode/settings.json Outdated Show resolved Hide resolved
examples/python/notebook/cube.ipynb Show resolved Hide resolved
scripts/ci/generate_pr_summary.py Outdated Show resolved Hide resolved
@jprochazk
Copy link
Member Author

Which ones aren't updated, and why?

One example is the example_manifest.json links. There's a difference between "link to the web viewer" and "link to the website that hosts web viewer assets". The latter is staying as app.rerun.io, because we have no way of hosting those assets at rerun.io/viewer or similar.

@jprochazk jprochazk merged commit 2d78f6a into main Apr 2, 2024
35 checks passed
@jprochazk jprochazk deleted the jan/update-viewer-links branch April 2, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants