Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selection history global instead of per recordings #5739

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Apr 2, 2024

What

The selection history is now global, so the back/forward button work as expected when selecting various recordings.

Note (quoting my comment in the original issue):

This is technically a functional regression. Before, we could have a different selection state for each recording (e.g "/world/robot" is selected in recording A and "/world/camera" is selected in recording B). However, in practice that's no longer true since recording have been made selectable: switching to a new recording now implies selecting said recording, in turn clearing the selection. This issue would make it harder to go back to the previous behaviour.

global-selection-history.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Apr 2, 2024
@jleibs jleibs merged commit a671f02 into main Apr 2, 2024
33 of 34 checks passed
@jleibs jleibs deleted the antoine/global-selection-history branch April 2, 2024 18:35
@emilk
Copy link
Member

emilk commented Apr 3, 2024

With this PR, the selection history if effectively cleared when you switch recordings/apps (because none of the entities, blueprints etc in one recording exist in the other, so their Items are invalid and pruned).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection history should be global
3 participants