Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent gratuitous blueprint saves by not gc'ing when the blueprint hasn't changed #5793

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Apr 4, 2024

What

Whenever we gc the blueprint, it bumps the generation, which in turn causes another save. By tracking the last gc, we never re-gc again if nothing has changed.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jleibs jleibs marked this pull request as ready for review April 4, 2024 16:20
@jleibs jleibs added 🟦 blueprint The data that defines our UI include in changelog labels Apr 4, 2024
@jleibs jleibs force-pushed the jleibs/fix_blueprint_noop_save branch from 0afe50c to b0543dc Compare April 4, 2024 16:34
@jleibs jleibs merged commit 464f4fc into main Apr 4, 2024
34 of 35 checks passed
@jleibs jleibs deleted the jleibs/fix_blueprint_noop_save branch April 4, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants