-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support displaying 1D tensors #5837
Conversation
1D tensors used to be visualized as bar charts - what happens to the heuristic around that now? See e.g. |
not entirely true ever since we introduced indicators. You have to have a bar chart indicator in order to be picked up as a bar chart automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked through and tested this a bit and it makes sense. @Wumpf is still fixing 1 edge case with creating bar chart from an existing tensor.
Hit this very related bug, but not going to address it here or for the release in general: |
What
Technically two separate fixes:
Test code:
Before:
After first commit:
After second commit:
Screen.Recording.2024-04-08.at.11.07.18.mov
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewer